Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG + 1] DOC avoid combining diacritics in author names #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

jnothman
Copy link
Member

Fixes latexpdf compilation

@lesteve
Copy link
Member

lesteve commented Oct 19, 2016

I bumped into exactly the same thing while trying to run make dist locally and this change definitely fixes the issue.

Out of curiosity, is LaTeX not supposed to be able to tackle unicode via \usepackage[utf8]{inputenc}?

@lesteve lesteve changed the title [MRG] DOC use unicode in author names [MRG + 1] DOC use unicode in author names Oct 19, 2016
@jnothman
Copy link
Member Author

at master:

$ grep -A1 Javier doc/whats_new.rst | hexdump -C
00000000  69 73 6d 73 2c 20 4a 61  6b 65 20 56 61 6e 64 65  |isms, Jake Vande|
00000010  72 50 6c 61 73 2c 20 4a  61 6e 20 44 6c 61 62 61  |rPlas, Jan Dlaba|
00000020  6c 2c 20 4a 61 6e 20 48  65 6e 64 72 69 6b 20 4d  |l, Jan Hendrik M|
00000030  65 74 7a 65 6e 2c 20 4a  61 74 69 6e 20 53 68 61  |etzen, Jatin Sha|
00000040  68 2c 20 4a 61 76 69 65  72 20 4c 6f cc 81 70 65  |h, Javier Lo..pe|
00000050  7a 0a 50 65 6e cc 83 61  2c 20 6a 64 63 61 62 61  |z.Pen..a, jdcaba|
00000060  6c 6c 65 72 6f 2c 20 4a  65 61 6e 20 4b 6f 73 73  |llero, Jean Koss|
00000070  61 69 66 69 2c 20 4a 65  66 66 20 48 61 6d 6d 65  |aifi, Jeff Hamme|
00000080  72 62 61 63 68 65 72 2c  20 4a 6f 65 6c 20 4e 6f  |rbacher, Joel No|
00000090  74 68 6d 61 6e 2c 20 4a  6f 6e 61 74 68 61 6e 0a  |thman, Jonathan.|
000000a0

Here:

$ grep -A1 Javier doc/whats_new.rst | hexdump -C
00000000  69 73 6d 73 2c 20 4a 61  6b 65 20 56 61 6e 64 65  |isms, Jake Vande|
00000010  72 50 6c 61 73 2c 20 4a  61 6e 20 44 6c 61 62 61  |rPlas, Jan Dlaba|
00000020  6c 2c 20 4a 61 6e 20 48  65 6e 64 72 69 6b 20 4d  |l, Jan Hendrik M|
00000030  65 74 7a 65 6e 2c 20 4a  61 74 69 6e 20 53 68 61  |etzen, Jatin Sha|
00000040  68 2c 20 4a 61 76 69 65  72 20 4c c3 b3 70 65 7a  |h, Javier L..pez|
00000050  0a 50 65 c3 b1 61 2c 20  6a 64 63 61 62 61 6c 6c  |.Pe..a, jdcaball|
00000060  65 72 6f 2c 20 4a 65 61  6e 20 4b 6f 73 73 61 69  |ero, Jean Kossai|
00000070  66 69 2c 20 4a 65 66 66  20 48 61 6d 6d 65 72 62  |fi, Jeff Hammerb|
00000080  61 63 68 65 72 2c 20 4a  6f 65 6c 20 4e 6f 74 68  |acher, Joel Noth|
00000090  6d 61 6e 2c 20 4a 6f 6e  61 74 68 61 6e 0a        |man, Jonathan.|
0000009e

It looks like LaTeX doesn't like the combining diacritics :/ This branch replaces them with the pre-composed forms.

@jnothman jnothman changed the title [MRG + 1] DOC use unicode in author names [MRG + 1] DOC avoid combining diacritics in author names Oct 19, 2016
@lesteve
Copy link
Member

lesteve commented Oct 19, 2016

It looks like LaTeX doesn't like the combining diacritics :/

Oh well ... fine with me.

@amueller amueller merged commit 387f25c into scikit-learn:master Oct 19, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 25, 2016
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants