[MRG] ENH Add a commit flag [ci recythonize] to recythonize all the sources. #7708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is nice! it looks good to me. thanks for fixing this. |
|
Nice idea. I'm torn between always disabling the cache and this. So +1/2 for this :) But please add dev docs |
|
Thanks. BTW do you think |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7094
What does this implement/fix? Explain your changes.
This provisions a
[ci recythonize]flag that can be added to commit messages to force a re-cythonize of all the cython sources.Any other comments?
In action - https://travis-ci.org/raghavrv/scikit-learn/jobs/169063232#L1513
@arthurmensch @ogrisel @amueller @jnothman @nelson-liu Pl. review :)