Fixes issue #7751 - #7807
Closed
visheshmistry wants to merge 4 commits into
Closed
Conversation
added 4 commits
November 1, 2016 15:09
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
Member
|
@vishesh9494 there is already a PR tackling this issue that was opened before yours #7802 by @kennmyers. Quickly looking at it it seems like #7802 is closer to being mergable than this PR so I am closing this one. @vishesh9494 sorry for the duplicated work, don't hesitate to look for another issue to work on. |
Author
|
@lesteve It is alright. I am really looking forward to contributing here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #7751
What does this implement/fix? Explain your changes.
In scikit-learn/sklearn/metrics/classification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
Any other comments?
The additional file - test1.py is for testing purpose and I have deleted it in my further commit