Create test_ovr_decision_function.py #7810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test should be added in #7724, closing. |
|
By the way this shows that the test you added fails on master which is exactly what we want for a regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Issue #6416
This is also inline with Pull Request: #7724
What does this implement/fix? Explain your changes.
I added a test for svm ovr case, the decision function value should give greater value for points further away from decision boundaries.
Any other comments?
Please help me if I created the PR wrongly, this PR is to add a test case, the other PR #7724 was to report the bug, thank you.