[MRG + 1] Reformat the version info and cite us labels in the user-guide docs. #8072
Conversation
* Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line.
|
|
| {%- endif %} | ||
| <p class="citing">If you use the software, please consider <a href="{{pathto('about')}}#citing-scikit-learn">citing scikit-learn</a>.</p> | ||
| <p class="citing"><b><a href="about.html#citing-scikit-learn" style="font-size: 110%;">Cite us </a></b>if you use the software.</p> |
There was a problem hiding this comment.
seeing as this takes up 2 lines anyway (thus perhaps no harm in adding some more text), how's "Please cite us if you use scikit-learn"?
There was a problem hiding this comment.
I agree, please sounds polite.
|
LGTM. To make the comparison easier: Master: |
|
I intended to display the "Other versions" link on a different line which worked with the "version 0.18" docs but according to the Circle CI link posted in the above comment, it looks to be broken out. Would you like me to put it explicitly on a new line? I also wanted to know what are we testing on Circle CI, Appveyor and Travis CI platforms in general and the reason for having three different ones. Thanks. |
|
Circleci is for building docs and doctests. Appveyor runs the unit tests on windows and TravisCI runs them on Linux + runs the lint test |
|
Not sure this fully fixes the original issue. I was looking for something that has less text and pops out more. the cite us is better and now 2 lines instead of 3, but the version went from 3 lines to four. Four lines doesn't really pop. |
…ide docs. (scikit-learn#8072) * Reformat the version info and cite us labels in the user-guide docs. * Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line. * Edit the sentence formation of "cite us" section.
…ide docs. (scikit-learn#8072) * Reformat the version info and cite us labels in the user-guide docs. * Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line. * Edit the sentence formation of "cite us" section.
…ide docs. (scikit-learn#8072) * Reformat the version info and cite us labels in the user-guide docs. * Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line. * Edit the sentence formation of "cite us" section.
…ide docs. (scikit-learn#8072) * Reformat the version info and cite us labels in the user-guide docs. * Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line. * Edit the sentence formation of "cite us" section.
…ide docs. (scikit-learn#8072) * Reformat the version info and cite us labels in the user-guide docs. * Fix the line break in the version number. * Refactor the cite us sentence to have cite us in the beginning of the line. * Edit the sentence formation of "cite us" section.
Reference Issue
Fixes #7021. Closes #7036.
What does this implement/fix? Explain your changes.