[MRG + 1] Add changelog entry for MSLE implemented in #7655. #8104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavrv
suggested changes
Dec 22, 2016
| @@ -41,6 +41,10 @@ New features | |||
| Kullback-Leibler divergence and the Itakura-Saito divergence. | |||
| By `Tom Dupre la Tour`_. | |||
|
|
|||
| - Added :func:`metrics.regression.mean_squared_log_error`, a risk metric | |||
There was a problem hiding this comment.
Added ..., which computes the mean of squares on the natural log of the error... or something like that...
The risk metric... seems unnecessary
|
Fine by me. @raghavrv, minor changes do not require double review. |
|
Hi @jnothman, @raghavrv I'm sorry for the inconvenience - I thought it should work but the hyperlink
is not being displayed. I guess it should have been simply This typo has to be fixed in Line 44. Is it fine this way / shall I submit a PR / could you make a typo fix directly on master ? |
|
the problem, i think, is .regression. Fixed, I hope.
…On 23 December 2016 at 16:20, Karan Desai ***@***.***> wrote:
Hi @jnothman <https://github.com/jnothman>, @raghavrv
<https://github.com/raghavrv> I'm sorry for the inconvenience - I thought
it should work but the hyperlink
[image: image]
<https://cloud.githubusercontent.com/assets/10494087/21447622/59f3f7ac-c8fd-11e6-932c-c57636590433.png>
is not being displayed. I guess it should have been simply
sklearn.metrics.mean_squared_log_error as it in imported in __init__.py
though I'm not sure whether this should turn back the hyperlink.
This typo has to be fixed in Line 44
<https://github.com/scikit-learn/scikit-learn/blob/master/doc/whats_new.rst>.
Is it fine this way / shall I submit a PR / could you make a typo fix
directly on master ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8104 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz64q2q-a-M29THuSm8idsnydWCqWiks5rK1o6gaJpZM4LT4zy>
.
|
|
Thanks @jnothman 😄 |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
None
What does this implement/fix? Explain your changes.
Adds an entry in CHANGELOG about the new regression metric, mean squared logarithmic error, implemented in #7655. It was missed out earlier.
Any other comments?
None