Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] DOC: updating GridSearchCV's n_jobs parameter - #8106

Merged
jnothman merged 1 commit into
scikit-learn:masterfrom
accraze:gridsearch-docs
Jan 4, 2017
Merged

[MRG+1] DOC: updating GridSearchCV's n_jobs parameter#8106
jnothman merged 1 commit into
scikit-learn:masterfrom
accraze:gridsearch-docs

Conversation

@accraze

@accraze accraze commented Dec 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reference Issue

Fixes #5797

What does this implement/fix? Explain your changes.

Clarify n_jobs for gridsearch in docs

Any other comments?

jnothman
jnothman reviewed Dec 23, 2016
View reviewed changes
Comment thread sklearn/grid_search.py Outdated

n_jobs: int, default: 1 :
The maximum number of concurrently running jobs, such as the number of
Python worker processes when backend=”multiprocessing” or the size of

@jnothman jnothman Dec 23, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user cannot really choose the backend here so this is too much information, I think.

Perhaps copy an n_jobs description from elsewhere in scikit-learn, rather than from joblib.parallel.

Also, please replicate your changes to RandomizedSearchCV.

@raghavrv raghavrv changed the title DOC: updating GridSearchCV's n_jobs parameter [WIP] DOC: updating GridSearchCV's n_jobs parameter Dec 28, 2016
@raghavrv raghavrv added this to the 0.19 milestone Dec 28, 2016
@accraze
accraze force-pushed the gridsearch-docs branch 2 times, most recently from ec0111c to 54bf333 Compare January 1, 2017 23:06
@accraze

accraze commented Jan 1, 2017

Copy link
Copy Markdown
Contributor Author

@jnothman thanks for the feedback, I made the necessary changes. Let me know if anything else needs to be fixed.

jnothman
jnothman reviewed Jan 2, 2017
View reviewed changes

@jnothman jnothman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread sklearn/grid_search.py Outdated
n_jobs : int, default=1
Number of jobs to run in parallel.
n_jobs: int, default: 1 :
The maximum number of concurrently running jobs.

@jnothman jnothman Jan 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be more explicit, "estimators fit in parallel"

@jnothman

jnothman commented Jan 2, 2017

Copy link
Copy Markdown
Member

Wait: doesn't this still need to be applied to RandomizedSearchCV?

@accraze

accraze commented Jan 3, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jnothman it was added to RandomizedSearchCV
https://github.com/accraze/scikit-learn/blob/5131d3ce0d426f74ece495572c7caa48d052d8d7/sklearn/grid_search.py#L900

@jnothman

jnothman commented Jan 3, 2017

Copy link
Copy Markdown
Member

Sorry for my slowness. LGTM

@jnothman jnothman changed the title [WIP] DOC: updating GridSearchCV's n_jobs parameter [MRG+1] DOC: updating GridSearchCV's n_jobs parameter Jan 3, 2017
tguillemot
tguillemot suggested changes Jan 3, 2017
View reviewed changes

@tguillemot tguillemot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nipticks otherwise LGTM.

Comment thread sklearn/grid_search.py Outdated

- For n_jobs below -1, (n_cpus + 1 + n_jobs) are used.

- For n_jobs = -2, all CPUs but one are used.

@tguillemot tguillemot Jan 3, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to merge the last two points. Maybe something like :

For ``n_jobs`` below -1, ``(n_cpus + n_jobs + 1)`` are used. For example, with ``n_jobs = -2`` all CPUs but one are used.

What do you think ?

@accraze accraze Jan 4, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@accraze
accraze force-pushed the gridsearch-docs branch 2 times, most recently from eca4339 to c2e48e0 Compare January 4, 2017 04:34
@accraze

accraze commented Jan 4, 2017

Copy link
Copy Markdown
Contributor Author

thanks for the review @tguillemot , I made the change but not sure why one of the appveyor tests is failing now....

@jnothman

jnothman commented Jan 4, 2017

Copy link
Copy Markdown
Member

Clearly not your fault. Merging, thanks!

@jnothman
jnothman merged commit c49ced9 into scikit-learn:master Jan 4, 2017
@tguillemot

tguillemot commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

Thx @accraze.

raghavrv pushed a commit to raghavrv/scikit-learn that referenced this pull request Jan 5, 2017
@accraze @raghavrv
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
acfc4a6 
fixes scikit-learn#5797
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@accraze @sergeyf
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
92b9892 
fixes scikit-learn#5797
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@accraze @Sundrique
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
53c3f8d 
fixes scikit-learn#5797
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@accraze @NelleV
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
bf2df4d 
fixes scikit-learn#5797
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@accraze @paulha
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
ecc9337 
fixes scikit-learn#5797
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@accraze @maskani-moh
DOC: updating GridSearchCV's n_jobs parameter (scikit-learn#8106)
f569dd6 
fixes scikit-learn#5797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnothman jnothman jnothman left review comments
+1 more reviewer
@tguillemot tguillemot tguillemot requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

Clarify n_jobs for gridsearch in docs

4 participants

@accraze @jnothman @tguillemot @raghavrv