[MRG] FIX Avoid default mutable argument in constructor of AgglomerativeClustering #8153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problem with putting in new validation is that now it needs a unit test :P |
|
Are you sure that it needs a unit test? It's the default argument, hence it is covered in the existing tests. |
|
I mean now there is an error raised if memory is not a |
|
I mean now there is an error raised if memory is not a str or a Memory,
but that line no longer has code coverage. So ideally there would be a
test that the right error is raised at the right time if memory=5.
Good point. Agreed.
|
|
Thanks @glemaitre |
raghavrv
pushed a commit
to raghavrv/scikit-learn
that referenced
this pull request
Jan 5, 2017
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
As pointed out in #7990,
joblib.Memoryis mutable. It was usedas a default argument of the constructor of
AgglomerativeClustering.This fix just pass
Noneand initialize atfittime thememorywiththe same behaviour as previously implemented.
Any other comments?