Change rstrip() to truncation in test function #8237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
In the
test_kernel_theta
function,s.rstrip('_bounds')
is used to strip "_bounds" from the end of a string. This is almost certainly a misuse of therstrip
function, which strips off any number of the characters in the argument from the end, so, for example:Normally I would just do
[s if not s.endswith('_bounds') else s[:-len('_bounds')] for s in args]
, but there's already afilter
onargs
that only takes values that already end with_bounds
.