[MRG+1] TST: added test for estimators supporting list of weights #8261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Feb 2, 2017
|
Sorry. I somehow ignored the fact that tests are failing. |
|
Yup. |
|
@jnothman Yes, working on it. |
|
A list is array-like. We want to support it. |
|
Oh. Sorry, I had misunderstood the meaning. I'll fix it. |
jnothman
reviewed
Feb 3, 2017
|
This looks good & tests are passing. +1 for merge from my side. Thanks! |
|
LGTM! Thanks! |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8064
What does this implement/fix? Explain your changes.
This adds a common test for all estimators showing that they support a list of weights as the value for the
sample_weightargument tofit.Any other comments?
Since the estimators didn't throw any error, I assume that they support it. So, I have just implemented something to get the PR going. Please provide feedback as to whether my approach is the correct one.