Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] Remove the MLComp text categorization example #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2017
Merged

[MRG+1] Remove the MLComp text categorization example #8264

merged 4 commits into from
Feb 8, 2017

Conversation

rth
Copy link
Member

@rth rth commented Feb 1, 2017

This PR fixes issue #8229 (document classification example should use 'latin-1' encoding) by removing the example (as suggested by @lesteve ).

This also raises a deprecation warning when load_mlcomp is used to load the 20 newsgoups example, where fetch_20newsgroups should preferably be used instead. However, as both datasets are not strictly identical, maybe that's not the best solution.

The MLComp text categorization example is mostly redundant with the other text categorization example while being less complete, and incites user to use a more complex way of loading the 20 newsgoups dataset via load_mlcomp instead of fetch_20newsgroups.

@lesteve
Copy link
Member

lesteve commented Feb 2, 2017 •
edited
Loading

This also raises a deprecation warning when load_mlcomp is used to load the 20 newsgoups example, where fetch_20newsgroups should preferably be used instead. However, as both datasets are not strictly identical, maybe that's not the best solution.

Chatting with @ogrisel he agrees that deprecating load_mlcomp is the way to go. According to http://mlcomp.org/, they are going to shut down the website in March 2017.

lesteve
lesteve reviewed Feb 2, 2017
View reviewed changes
sklearn/datasets/mlcomp.py Outdated
@@ -68,6 +68,11 @@ def load_mlcomp(name_or_id, set_="raw", mlcomp_root=None, **kwargs):
if not os.path.exists(mlcomp_root):
raise ValueError("Could not find folder: " + mlcomp_root)

if name_or_id in ['20news-18828', '20news-19997', '20news-bydate']:
raise DeprecationWarning("please consider using "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecate the whole function with a @deprecated decorator. Also mention which version it will be deprecated in (0.19) and which version it will be removed (0.21). Look either at the contributing guidelines or other deprecation messages in the scikit-learn code.

@rth
Copy link
Member Author

rth commented Feb 2, 2017

Thanks for the review @lesteve . I addressed your comments.

@lesteve
Copy link
Member

lesteve commented Feb 2, 2017 •
edited
Loading

The MLComp text categorization example is mostly redundant with the other text categorization example while being less complete

Can I get a second opinion on this? @raghavrv or @jnothman for example.

jnothman
jnothman reviewed Feb 3, 2017
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps note somewhere in docs (deprecation message or docstring) that the site itself is closing down. Otherwise LGTM

@jnothman jnothman changed the title [MRG] Remove the MLComp text categorization example [MRG+1] Remove the MLComp text categorization example Feb 3, 2017
@rth
Copy link
Member Author

rth commented Feb 3, 2017

Thanks for the review @jnothman ! I addressed your comment.
CI is failing due to travis-ci/travis-ci#7264, will try to trigger a new build a bit later..

@lesteve
Copy link
Member

lesteve commented Feb 7, 2017

The Travis problem has been fixed, I have restarted the build.

@lesteve
Copy link
Member

lesteve commented Feb 8, 2017

Looks good, merging, thanks a lot!

@lesteve lesteve merged commit 542c02b into scikit-learn:master Feb 8, 2017
@rth rth deleted the mlp_example branch February 8, 2017 09:50
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@rth @sergeyf
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
a85943c 
)

and deprecate load_mlcomp.
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@rth @Sundrique
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
ee79716 
)

and deprecate load_mlcomp.
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@rth @NelleV
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
96bc0fb 
)

and deprecate load_mlcomp.
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@rth @paulha
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
45a93ac 
)

and deprecate load_mlcomp.
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@rth @maskani-moh
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
7a88825 
)

and deprecate load_mlcomp.
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this pull request Jan 6, 2021
@rth
[MRG+1] Remove the MLComp text categorization example (scikit-learn#8264
45fa802 
)

and deprecate load_mlcomp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@lesteve lesteve lesteve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rth @lesteve @jnothman