Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: related_projects.rst: fixes bug in parsing xgboost link #8270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

manu-chroma
Copy link
Contributor

Reference Issue

Fixes #8269

What does this implement/fix? Explain your changes.

parses link to xgboost github repo correctly

Any other comments?

image

@lesteve
Copy link
Member

lesteve commented Feb 2, 2017

No need to wait for the CIs for this one. Thanks a lot, merging.

Small comment: the convention is to start your PR title with [MRG] when it is ready for review, have a look at https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md for more details.

@lesteve lesteve merged commit c48ea04 into scikit-learn:master Feb 2, 2017
@manu-chroma
Copy link
Contributor Author

thanks @lesteve
I made a few PR's in sckit-learn last summer. Completely forgot to add [MRG] in the beginning!

@lesteve
Copy link
Member

lesteve commented Feb 2, 2017

I made a few PR's in sckit-learn last summer. Completely forgot to add [MRG] in the beginning!

No big deal but first impression matters and it is a good idea to try to follow contribution guidelines.

@manu-chroma
Copy link
Contributor Author

sure. thanks for the tip :)

@manu-chroma manu-chroma deleted the fix_link_error branch February 17, 2017 12:50
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: related projects page: xgboost link is not correctly parsed
2 participants