[MRG] loss function plot y-label slightly confusing #8283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should avoid to open PR from your master branch, please avoid doing that on your next PR. Can you rebase on master to see whether the CircleCI disappears? |
|
Yep, I will take cake of this in my next PR. I'm learning about concept of rebasing and will soon rebase on master. Thanks for your suggestion @lesteve. |
|
I don't know about travis-ci but the circleci test has passed after rebasing . Is it OK or not ? Can any one suggest. Thanks |
jnothman
reviewed
Feb 6, 2017
| @@ -38,5 +38,5 @@ def modified_huber_loss(y_true, y_pred): | |||
| plt.ylim((0, 8)) | |||
| plt.legend(loc="upper right") | |||
| plt.xlabel(r"Decision function $f(x)$") | |||
| plt.ylabel("$L(y, f(x))$") | |||
| plt.ylabel("$L(y = 1, f(x))$") | |||
There was a problem hiding this comment.
@amueller suggested L(y=1, ... and I don't really see how the spaces increase clarity.
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
* Correct y label in plot * Remove Space
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Correct y label in plot * Remove Space
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* Correct y label in plot * Remove Space
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Correct y label in plot * Remove Space
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Correct y label in plot * Remove Space
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
* Correct y label in plot * Remove Space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8275
What does this implement/fix? Explain your changes.
Making y label more clear i.e
L(y = 1, f(x))Any other comments?