DOC: Remove superfluous assignment in tutorial. issue #8285 #8314
Conversation
per recommendation
|
When doctest is run on these, it will expect output if the return value is not None. The previous code ensured the return value is None. |
Ah fair point, I did not think of that. Weird that the tests are passing then ... maybe something slightly wrong with the way doctests are run ?
Congrats, it looks good overall. Next time please create a feature branch, i.e. do not create a PR from your master branch. |
|
Yes, I agree it seems these doctests are not being run by CI.
…On 8 February 2017 at 17:36, Loïc Estève ***@***.***> wrote:
The previous code ensured the return value is None.
Ah fair point, I did not think of that. Weird that the tests are passing
then ... maybe something slightly wrong with the way doctests are run ?
This is my first PR to the project
Congrats, it looks good overall. Next time please create a feature branch,
i.e. do not create a PR from your master branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8314 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6yjh0yHeUK8jgmTEmCbS7HsataYhks5raWJkgaJpZM4L6Uen>
.
|
There is a fixture in doc/tutorial/text_analytics/working_with_text_data_fixture.py that skips the doctest because it needs dataset to be downloaded. |
|
I pushed a change that should fix the doctests. |
|
LGTM |
|
Thanks @seanpwilliams |
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
… (scikit-learn#8314) * remove assignment per recommendation * Fix doctests
Reference Issue
Fixes #8285
What does this implement/fix? Explain your changes.
I thought there was an odd bit of code in the tutorial, regarding the name chosen in an assignment. Per recommendation from lesteve, I just removed the assignment entirely.
Any other comments?
This is my first PR to the project; I hope I'm submitting according to the guidelines. Let me know if I'm not, feel free to point me towards a way to remedy it, and I'll do so.