[WIP] Pytest test suite completely independent of nose #8321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
This PR was continued in #11074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses issue #7319
What does this implement/fix? Explain your changes.
With this PR I replace nosetest by py.test. Surprised how easy the port was in general.
pytest.mark.parametrizein many places that featuredyield-style tests.assert_trueandassert_false, etc.This PR is not as polished as I would normally prepare a PR to be, maybe with some feedback & help , especially with regards to the CI infrastructure, we can get it into a mergeable state.
PS: As far as I can tell, flake8 is used for style checks, I would suggest moving to https://pypi.python.org/pypi/pytest-flake8 which integrates nicely with flake8.