-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Change "observations" to "features" in description of LassoLarsCV #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
indeed thx @cbrummitt |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
…ikit-learn#8362) The description of LassoLarsCV compared the number of samples with the number of observations, but it was meant to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: > However, :class:`LassoLarsCV` has the advantage of exploring more relevant values of `alpha` parameter, and if the number of samples is very small compared to the number of observations, it is often faster than :class:`LassoCV`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of LassoLarsCV compared the number of samples with the number of observations, but I think the author intended to compare the number of samples to the number of features (or dimensions) of the data. I changed "observations" to "features" in the following sentence: