Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plot iso-f1 curves in plot_precision_recall #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

plot iso-f1 curves in plot_precision_recall #8366

wants to merge 1 commit into from

Conversation

SACHIN-13
Copy link
Contributor

@SACHIN-13 SACHIN-13 commented Feb 15, 2017 •
edited
Loading

Reference Issue

Fixes #8313

What does this implement/fix? Explain your changes.

while plotting PR curves, it separates out the curves with equal f1 values.

@codecov
Copy link

codecov bot commented Feb 15, 2017

Codecov Report

Merging #8366 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8366   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         342      342           
  Lines       60801    60801           
=======================================
  Hits        57609    57609           
  Misses       3192     3192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d57730...9ee1b4d. Read the comment docs.

jnothman
jnothman reviewed Feb 15, 2017
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had intended these to appear under the existing plots, not as a new figure.

examples/model_selection/plot_precision_recall.py
@@ -127,6 +127,21 @@
average="micro")


# Plot ISO-F1 curve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO is international standards organisation. "Iso-" is a greek-derived prefix meaning equal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah yes, will change it!

@jnothman
Copy link
Member

Also, I think the calls to plot.clf() mean that only a single figure shows in the rendered documentation when we would like multiple.

@SACHIN-13
Copy link
Contributor Author

wont the figure become clumsy if we add the iso-f1 curves in the existing plots!??

@jnothman
Copy link
Member

jnothman commented Feb 16, 2017 via email

@SACHIN-13
Copy link
Contributor Author

i am sorry but it wasn't clear

@jnothman
Copy link
Member

jnothman commented Feb 16, 2017 via email

@SACHIN-13 SACHIN-13 closed this Feb 16, 2017
@SACHIN-13 SACHIN-13 deleted the my-feature branch February 16, 2017 19:28
@SACHIN-13 SACHIN-13 mentioned this pull request Feb 16, 2017
Merged
@jnothman
Copy link
Member

jnothman commented Feb 16, 2017 via email

@SACHIN-13
Copy link
Contributor Author

I deleted the branch from my fork by mistake.
A new PR #8378

@ogrisel
Copy link
Member

ogrisel commented Feb 17, 2017

Can you please include a screenshot of the plot in the pull request?

@SACHIN-13
Copy link
Contributor Author

Yes.. refer to #8378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot iso-F1 curves in plot_precision_recall
3 participants
@SACHIN-13 @jnothman @ogrisel