Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] fixes irc url for issue #8382 #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2017

Conversation

i-am-xhy
Copy link
Contributor

@i-am-xhy i-am-xhy commented Feb 17, 2017

fixes #8382

@codecov
Copy link

codecov bot commented Feb 17, 2017

Codecov Report

Merging #8383 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8383   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         342      342           
  Lines       60801    60801           
=======================================
  Hits        57609    57609           
  Misses       3192     3192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8694278...6795a5c. Read the comment docs.

@lesteve
Copy link
Member

lesteve commented Feb 17, 2017

LGTM, but I have to say I have very rarely used IRC, so I'd rather wait for a second opinion.

@lesteve lesteve changed the title fixes irc url for issue #8382 [MRG+1] fixes irc url for issue #8382 Feb 17, 2017
@jnothman
Copy link
Member

Thanks. Not that I use IRC either, so I'm not sure how up-to-date the overall statement is. But at least this will fix the URL.

@jnothman jnothman merged commit 38f23cc into scikit-learn:master Feb 19, 2017
@i-am-xhy i-am-xhy deleted the newIrcChannel branch February 19, 2017 22:21
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

irc link points to default apache page
3 participants