Test for class_weights when using a dictionary and referring to an invalid class #8387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MMeketon travis complains. Please have a look why. |
|
Joel – I’m sorry, I thought I did merge this into the Pull Request. Obviously I’m a bit lost. I will ask for help from someone I know at work. This might take another day.
I realize that this, for you, is very simple. But I’m not familiar with all the steps here. Sigh.
From: Joel Nothman [mailto:[email protected]]
Sent: Sunday, February 19, 2017 8:42 AM
To: scikit-learn/scikit-learn
Cc: Meketon, Marc; Mention
Subject: Re: [scikit-learn/scikit-learn] Test for class_weights when using a dictionary and referring to an invalid class (#8387)
No doubt it complains because this commit should be part of #8319<#8319>. @MMeketon<https://github.com/MMeketon>, could you try to merge this commit into that PR's branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#8387 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMpYD6PfDu3-ih_rnPoXIwr3ZfJ9iJEQks5reEaOgaJpZM4MEzh_>.
…________________________________
This e-mail and any attachments may be confidential or legally privileged. If you received this message in error or are not the intended recipient, you should destroy the e-mail message and any attachments or copies, and you are prohibited from retaining, distributing, disclosing or using any information contained herein. Please inform us of the erroneous delivery by return e-mail. Thank you for your cooperation.
|
|
no problem. i could give some tips, but it may be easier with a colleague's
assistance
…On 20 Feb 2017 1:36 am, "Marc Meketon" ***@***.***> wrote:
Joel – I’m sorry, I thought I did merge this into the Pull Request.
Obviously I’m a bit lost. I will ask for help from someone I know at work.
This might take another day.
I realize that this, for you, is very simple. But I’m not familiar with
all the steps here. Sigh.
From: Joel Nothman ***@***.***
Sent: Sunday, February 19, 2017 8:42 AM
To: scikit-learn/scikit-learn
Cc: Meketon, Marc; Mention
Subject: Re: [scikit-learn/scikit-learn] Test for class_weights when using
a dictionary and referring to an invalid class (#8387)
No doubt it complains because this commit should be part of #8319<
#8319>. @MMeketon<
https://github.com/MMeketon>, could you try to merge this commit into
that PR's branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
scikit-learn/scikit-learn#8387#issuecomment-280919864>, or mute the
thread<https://github.com/notifications/unsubscribe-auth/AMpYD6PfDu3-ih_
rnPoXIwr3ZfJ9iJEQks5reEaOgaJpZM4MEzh_>.
________________________________
This e-mail and any attachments may be confidential or legally privileged.
If you received this message in error or are not the intended recipient,
you should destroy the e-mail message and any attachments or copies, and
you are prohibited from retaining, distributing, disclosing or using any
information contained herein. Please inform us of the erroneous delivery by
return e-mail. Thank you for your cooperation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8387 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz627ypVlILhaKFQ-yIqhkQuzacVYCks5reFNQgaJpZM4MEzh_>
.
|
|
Closed because the test was incorrectly put into this branch. It is now is the #8319 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
This adds a test called "test_class_weight_with_string_label" that sees if an illegal non-integer class defined in "class_weights" will raise the ValueError. When this test is run on the original code, there is an error that occurs but when run on the revised code it passes the test.
Any other comments?