Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG+1] Modify gaussian_process examples for matplotlib v2 comp #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2017
Merged

[MRG+1] Modify gaussian_process examples for matplotlib v2 comp #8394

merged 7 commits into from
Jun 19, 2017

Conversation

rishikksh20
Copy link
Contributor

@rishikksh20 rishikksh20 commented Feb 18, 2017

Reference Issue

#8364

What does this implement/fix? Explain your changes.

Add edgecolors attribute in scatter plot.

Any other comments?

Please verify all example plots using following links :

@codecov-io
Copy link

codecov-io commented Feb 18, 2017

Codecov Report

Merging #8394 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8394   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         342      342           
  Lines       60902    60902           
=======================================
  Hits        57708    57708           
  Misses       3194     3194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daeba62...f8648b5. Read the comment docs.

@agramfort
Copy link
Member

agramfort commented Feb 19, 2017

LGTM

who gave the first +1?

@rishikksh20 rishikksh20 changed the title [MRG+1] Modify gaussian_process examples for matplotlib v2 comp [MRG] Modify gaussian_process examples for matplotlib v2 comp Feb 19, 2017
@rishikksh20
Copy link
Contributor Author

@agramfort no one thats my mistake.

@agramfort agramfort changed the title [MRG] Modify gaussian_process examples for matplotlib v2 comp [MRG+1] Modify gaussian_process examples for matplotlib v2 comp Feb 19, 2017
@jnothman
Copy link
Member

plot_gpr_noisy is annotating its colorbar in the bottom figure with 6 significant figures, which is not only inappropriate, but makes the figure squeeze into a smaller space. Could we cut this back to 2 sig fig or similar?

In plot_gpr_prior_posterior, the grey fill is too dark relative to the plot colours. Could you please make it lighter?

@rishikksh20
Copy link
Contributor Author

@jnothman I have lighted down the grey fill in plot_gpr_prior_posterior. But I enable to understand your concern regrading plot_gpr_noisy .

@jnothman
Copy link
Member

The colorbar is the thing on the right showing the range of colours. In the latest version, this has numbers like 1.11111 which makes it take up a lot of space when 1.1 has as much useful information

Add edgecolors option in scatter plot

Issue: #8364
Add edgecolors option in scatter plot

Issue: #8364
Add edgecolors attribute in scatter plot

Issue: #8364
Add edgecolors attribute in scatter plot.

Issue: #8364
Modify file to pass travis build
Reduce `alpha` for better plot.

Issue: #8364
Modify colorbar in contour plot.

Issue: #8364
@jnothman jnothman added this to the 0.19 milestone Jun 18, 2017
@amueller
Copy link
Member

LGTM

@amueller amueller merged commit d9b525a into scikit-learn:master Jun 19, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
…it-learn#8394)

* Modify plot_gpc_xor.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for matplotlib v2 comp

Add edgecolors option in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpr_prior_posterior for matplotlibv2

Add edgecolors attribute in scatter plot

Issue: scikit-learn#8364

* Modify plot_gpc.py for matplotlib v2 comp

Add edgecolors attribute in scatter plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py to remove flake8 error

Modify file to pass travis build

* Cosmetic change in plot_gpr_prior_posterior

Reduce `alpha` for better plot.

Issue: scikit-learn#8364

* Modify plot_gpr_noisy.py for better visualization

Modify colorbar in contour plot.

Issue: scikit-learn#8364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants