[MRG] Travis add coverage to Python 3 build and oldest version build #8435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8435 +/- ##
==========================================
+ Coverage 94.75% 95.47% +0.72%
==========================================
Files 342 342
Lines 60902 60902
==========================================
+ Hits 57708 58149 +441
+ Misses 3194 2753 -441
Continue to review full report at Codecov.
|
|
Codecov report looks good, merging. |
|
Thank you
…On 23 Feb 2017 1:56 am, "Loïc Estève" ***@***.***> wrote:
Merged #8435 <#8435>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8435 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz60JMD2ADEH_AACneId6vrloOxmvGks5rfEy0gaJpZM4MIn8Z>
.
|
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making sure that the CIs pass and that the codecov looks fine, before I merge it.
codecov can combine the information from multiple builds.
The reason for adding Python 3 to the coverage is obvious. While I was at it I enabled coverage in the "oldest versions" build, there may be some coverage information that does not overlap with the other builds, e.g. in sklearn.utils.fixes.