Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] removed download_url in setup.py #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

shubham0704
Copy link

@shubham0704 shubham0704 commented Mar 4, 2017

Reference Issue

Fix #8184. Closes #8205.

What does this implement/fix? Explain your changes.

Removed DOWNLOAD_URL

Any other comments?

@GaelVaroquaux
Copy link
Member

Is the consensus that we want to remove the download URL? I would have thought about changing it to point to pypi?

@shubham0704
Copy link
Author

shubham0704 commented Mar 4, 2017

I made some tests as pointed by @lesteve. Our conversations can be checked in the previous commit for the same issue by some other author @GaelVaroquaux .Thanks.

@codecov
Copy link

codecov bot commented Mar 4, 2017

Codecov Report

Merging #8513 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8513   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         342      342           
  Lines       60913    60913           
=======================================
  Hits        58160    58160           
  Misses       2753     2753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c892c...02c027b. Read the comment docs.

@lesteve
Copy link
Member

lesteve commented Mar 6, 2017

Is the consensus that we want to remove the download URL? I would have thought about changing it to point to pypi?

Then you have a link on PyPI that points to the page you are already on. I don't think it adds anything.

Thanks @shubham0704 for going through the tests I mentioned in #8205 (comment). For next time, use your PR to comment on the tests you did rather than someone else's PR. For further reference they are here.

I am going to merge this one, I feel there was enough discussion already given the limited scope of this change and it is easy enough to revert it, if we bump into a unintended side-effect, which I doubt.

@lesteve lesteve merged commit 5135c56 into scikit-learn:master Mar 6, 2017
@shubham0704
Copy link
Author

Sure @lesteve . Thanks a lot.

@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI links to sourceforge instead of github
3 participants