Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] Modify Classification module example matplotlibv2 #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2017
Merged

[MRG] Modify Classification module example matplotlibv2 #8516

merged 5 commits into from
Mar 13, 2017

Conversation

rishikksh20
Copy link
Contributor

@rishikksh20 rishikksh20 commented Mar 4, 2017 •
edited
Loading

Reference Issue

#8364

What does this implement/fix? Explain your changes.

Add edgecolors attribute to scatter plot and markeredgecolors attribute to plot.

Any other comments?

  1. plot_classifier_comparison.py :
    Stable: http://scikit-learn.org/stable/auto_examples/classification/plot_classifier_comparison.html
    Dev: http://scikit-learn.org/dev/auto_examples/classification/plot_classifier_comparison.html
    PR: https://9277-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/auto_examples/classification/plot_classifier_comparison.html

  2. plot_lda_qda.py :
    Stable: http://scikit-learn.org/stable/auto_examples/classification/plot_lda_qda.html
    Dev: http://scikit-learn.org/dev/auto_examples/classification/plot_lda_qda.html
    PR: https://9277-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/auto_examples/classification/plot_lda_qda.html

@rishikksh20
Modify classifier comarision for matplotlib v2
fd02029 
Add `edgecolors` attribute to scatter plot
@rishikksh20
Modify plot_lda_qda for matplotlib v2
7f307a0 
Add `markeredgecolors` attribute in plot
@rishikksh20
Modify to remove flake8 error
9b627eb 
Remove extra indentation
@codecov
Copy link

codecov bot commented Mar 4, 2017

Codecov Report

Merging #8516 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8516   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         342      342           
  Lines       60913    60913           
=======================================
  Hits        58160    58160           
  Misses       2753     2753

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd693b...9b627eb. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2017 •
edited
Loading

Codecov Report

Merging #8516 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8516      +/-   ##
==========================================
+ Coverage   95.48%   95.48%   +<.01%     
==========================================
  Files         342      342              
  Lines       60913    61013     +100     
==========================================
+ Hits        58160    58259      +99     
- Misses       2753     2754       +1
Impacted Files Coverage Δ
sklearn/model_selection/_split.py 98.6% <0%> (-0.17%) ❌
sklearn/ensemble/gradient_boosting.py 95.79% <0%> (ø) ✅
sklearn/feature_selection/univariate_selection.py 99.46% <0%> (ø) ✅
sklearn/calibration.py 98.87% <0%> (ø) ✅
sklearn/model_selection/init.py 100% <0%> (ø) ✅
sklearn/gaussian_process/tests/test_kernels.py 98.86% <0%> (+0.01%) ✅
sklearn/metrics/tests/test_common.py 99.52% <0%> (+0.01%) ✅
sklearn/utils/estimator_checks.py 93.36% <0%> (+0.08%) ✅
sklearn/model_selection/tests/test_split.py 95.96% <0%> (+0.25%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd693b...383a8ca. Read the comment docs.

@jmschrei
Copy link
Member

jmschrei commented Mar 4, 2017

The first one I can see a minor difference, but I can't see a big difference in the second one. What change did you make there?

@rishikksh20
Copy link
Contributor Author

rishikksh20 commented Mar 4, 2017 •
edited
Loading

@jmschrei actually I've just added edgecolors parameter with k value in plots as from matplotlib version 2.0 default edgecolors is None instead of Black i.e. k.

@lesteve
Copy link
Member

lesteve commented Mar 10, 2017

I think plot_lda_qda does not need to be changed, i.e. the way it looks is fine with matplotlib 2.

For plot_classifier_comparison.py, with the lack of black edge color, the red points looks overly bright so I would be +1 for adding edge colors. For consistency can you add the edge colors on the most left plots as well?

@rishikksh20
Modify example for better plot
cd6d3b8 
Modify both example as per discussion in PR request.
@rishikksh20
Modify to remove pep8 error
383a8ca 
Remove extra space.
@lesteve
Copy link
Member

lesteve commented Mar 13, 2017

OK I am going to merge this one. I bumped into #8364 (comment) with seems to match my "overly bright" statement above.

@amueller please shout if it still hurts your eyes:
https://9451-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/auto_examples/classification/plot_classifier_comparison.html

Thanks @rishikksh20!

@lesteve lesteve merged commit 0ee92d8 into scikit-learn:master Mar 13, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@rishikksh20 @herilalaina
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
35bf403 
…#8516)
@amueller
Copy link
Member

amueller commented Apr 5, 2017

Huh How did I just notice that that got fixed? Interesting. No, I'm very happy now! Thanks @rishikksh20

massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@rishikksh20
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
6054b5f 
…#8516)
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@rishikksh20 @Sundrique
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
c423da3 
…#8516)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@rishikksh20 @NelleV
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
c0ec091 
…#8516)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@rishikksh20 @paulha
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
0f1d7bc 
…#8516)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@rishikksh20 @maskani-moh
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
4704dc1 
…#8516)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@rishikksh20
[MRG] Modify Classification module example matplotlibv2 (scikit-learn…
c2058bf 
…#8516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishikksh20 @jmschrei @lesteve @amueller