[MRG] Fixing wrapping in named_test.test_common #8558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis error is a flake8 error that you need to fix. Please invest some time to configure on-the-fly flake8 checks inside your editor of choice. This allows you to spot these kind of problems while editing. |
raghavrv
reviewed
Mar 14, 2017
| # matrix instead of a number. Testing of | ||
| # confusion_matrix with sample_weight is in | ||
| # test_classification.py | ||
| "confusion_matrix", # Left this one here because the tests in this file do |
There was a problem hiding this comment.
This is fine for now but from next time kindly avoid unrelated changes :)
| invalids =[([0, 1], [np.inf, np.inf]), | ||
| ([0, 1], [np.nan, np.nan]), | ||
| ([0, 1], [np.nan, np.inf])] | ||
| invalids = [([0, 1], [np.inf, np.inf]), |
lesteve
reviewed
Mar 14, 2017
| def test_sample_weight_invariance(n_samples=50): | ||
| # iterate through each metric testing each case | ||
| for metrics in generate_sample_weight_invariance(n_samples): | ||
| pass |
There was a problem hiding this comment.
I don't understand the original issue as I commented there and I don't think you need this since nose supports yield in test functions ...
|
Does this PR fixes the corresponding issue? Otherwise I might want to try to fix this. |
|
I am going to close this PR due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue #8507
What does this implement/fix? Explain your changes.
The issue is common to five functions. Not only test_sample_weight_invariance. However, this pull request only fixes test_sample_weight_invariance.
The functions:
are generative functions made to yield a particular output. However, the test simply calls the generator function without iterating through them. This change fixes that, by defining an additional function to iterate through each metric.
Any other comments?
These functions were added in commit #7620.