-
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
[MRG] Add verbose option for Pipeline and Feature Union. #8568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09f3332
ENH Add verbose option and corresponding tests for Pipeline.
a990034
ENH Add verbose option and corresponding tests for FeatureUnion.
49eadee
ENH Add _pretty_print method to print from Pipeline properly.
a3abe8d
Add a changelog entry about verbosity of Pipeline.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,10 @@ New features | |
| Enhancements | ||
| ............ | ||
|
|
||
| - Added optional parameter ``verbose`` in :class:`pipeline.Pipeline` and | ||
| :class:`pipeline.FeatureUnion` for showing progress and timing of each | ||
| step. :issue:`8568` by :user:`Karan Desai <karandesai-96>`. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add your name and link to the bottom of the page :)
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done ✅ |
||
|
|
||
| - Update Sphinx-Gallery from 0.1.4 to 0.1.7 for resolving links in | ||
| documentation build with Sphinx>1.5 :issue:`8010`, :issue:`7986` | ||
| :user:`Oscar Najera <Titan-C>` | ||
|
|
@@ -5059,4 +5063,6 @@ David Huard, Dave Morrill, Ed Schofield, Travis Oliphant, Pearu Peterson. | |
| .. _Anish Shah: https://github.com/AnishShah | ||
|
|
||
| .. _Neeraj Gangwar: http://neerajgangwar.in | ||
| .. _Arthur Mensch: https://amensch.fr | ||
| .. _Arthur Mensch: https://amensch.fr | ||
|
|
||
| .. _Karan Desai: https://www.github.com/karandesai-96 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an irrelevant detail, maybe use ellipsis? (
...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm ambiguous on this...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well then i'll wait for others' suggestion meanwhile. I'm not sure which should be preferred either.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set an analogy,
transformer_weightsare shown here in same documentation. They're not having any value in this particular example.We can use this as a tie breaker 😆