DOC Updated the Gaussian Mixture model image and link - #8665
DOC Updated the Gaussian Mixture model image and link#8665VathsalaAchar wants to merge 1 commit into
Conversation
Fix for issue scikit-learn#8664 Additional changes * updated the underline to match the line length above * fixed the link from the image to the example code
|
Thanks a lot for your PR. The issue has been fixed in master as you have noticed (original issues are #8168 and #8483). AFAIK we don't tend to merge documentation fixes into the maintenance branch. We just live with the fact that the dev documentation may have a few fixes compared to the stable doc. @jnothman any opinions on this? In any case we should just cherry-pick 4910e11 and b379060. Also a side-effect of adding a commit into 0.18.X is that matplotlib 2 will be used and some of our examples may not look very good with it. See #8364 for more details. |
|
Yes, we don't usually merge into released branches
…On 29 Mar 2017 11:07 pm, "Loïc Estève" ***@***.***> wrote:
Thanks a lot for your PR. The issue has been fixed in master as you have
noticed (original issue is #8168
<#8168>).
AFAIK we don't tend to merge documentation fixes into the maintenance
branch. We just live with the fact that the dev documentation may have a
few fixes compared to the stable doc. @jnothman
<https://github.com/jnothman> any opinions on this?
In any case we should just cherry-pick 4910e11
<4910e11>
and b379060
<b379060>
.
Also a side-effect of adding a commit into 0.18.X is that matplotlib 2
will be used and some of your examples may not look very good with it. See
#8364 <#8364> for more
details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8665 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz60ruZPh0r5snTuIf0J0Y4bfsatFoks5rqkmbgaJpZM4MsvK2>
.
|
OK I am going to close this one. @VathsalaAchar feel free to find another issue to work on if you feel like it, there should be plenty available ;-). |
|
Cool, it just bothered me while I was having a look around and I got lost with the link being wrong. And I'll definitely have a look at the other issues, thanks :) |
Fix for issue #8664
Additional changes