Codestin Search App

massich · 2017-05-09T16:47:47Z

Reference Issue

Fixes #8679

What does this implement/fix? Explain your changes.

This PR takes over the PR #8817 'cos it seems dead

Any other comments?

glemaitre · 2017-05-09T16:50:25Z

LGTM

jnothman · 2017-05-09T21:49:15Z

I think in the world of voluntary contributions, presuming something dad after a week without asking is a bit ... presumptuous

…

On 10 May 2017 2:47 am, "Joan Massich" ***@***.***> wrote: Reference Issue Add short explanation of regression test do contributing docs. #8679 <#8679> What does this implement/fix? Explain your changes. This PR takes over the PR #8879 'cos it seem dead Any other comments? ------------------------------ You can view, comment on, or merge this pull request online at: #8850 Commit Summary - DOC ask for non-regression test for bug-fix - Apply changes recomended in PR8817 - address all the changes in the previous PR - Remove tailing spaces File Changes - *M* doc/developers/contributing.rst <https://github.com/scikit-learn/scikit-learn/pull/8850/files#diff-0> (3) Patch Links: - https://github.com/scikit-learn/scikit-learn/pull/8850.patch - https://github.com/scikit-learn/scikit-learn/pull/8850.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8850>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6xC71wZepSJtrdvFc3oq_35Tl8q7ks5r4Ji0gaJpZM4NVlmK> .

naoyak · 2017-05-10T07:26:14Z

Travis failure is unrelated and should be fixed by re-triggering the build: https://github.com/kennethreitz/requests/issues/4006

massich · 2017-05-10T09:07:53Z

@jnothman I see. I'll do next time. My apologies to @puneetmathurDS.

lesteve · 2017-05-10T09:24:24Z

2 comments:

I would check CONTRIBUTING.md as well to see whether the same information can fit there as well
Maybe I would very quickly explain what a regression test is (basically fails on master, pass on your feature branch). People who need to read these instructions may not be familiar with what a regression test is.

[PR8817](scikit-learn#8817)

massich · 2017-05-10T09:55:00Z

@lesteve CONTRIBUTING.md has no section regarding converage. Only a bullet list telling you how to check coverage. However, both CONTRIBUTING.md and contributing.rst have a section regarding BUGFIX, Shall we explain the non-regression test there?

BTW, is there anyway to link RST and MD files so that only one needs to be edited?

lesteve · 2017-05-10T12:15:11Z

@lesteve CONTRIBUTING.md has no section regarding converage. Only a bullet list telling you how to check coverage. However, both CONTRIBUTING.md and contributing.rst have a section regarding BUGFIX, Shall we explain the non-regression test there?

Use your best judgement.

BTW, is there anyway to link RST and MD files so that only one needs to be edited?

Nope, this is a bit unfortunate but there you go.

Side-comment: I am not 100% sure about this but because we use squash and merge it is very likely that the commits in master will appear under the name of the first committer. You did not really use anything in the original PR so starting from scratch was probably the best way forward.

massich · 2017-05-10T14:24:11Z

Actually both have a Filing Bug section not a BugFix section. If you file a bug you don't have to supply a non-regression test. So it should not go here.

massich · 2017-05-10T14:47:41Z

I've moved the explanation to somewhere that was making more or less sense and that it was common to both files. Maybe needs some rewriting.

massich · 2017-05-11T11:55:47Z

I addressed the comments. (see artifact )

ping @lesteve

lesteve · 2017-05-11T13:34:00Z

The best place I could find where to add this piece of information was in the same bullet point as "Documentation and high-coverage tests are necessary for enhancements to be accepted."

massich · 2017-05-15T09:02:38Z

Moved right after @lesteve suggested sentence. (see artifact)

glemaitre · 2017-05-17T09:42:42Z

-   to be accepted.
+-  Documentation and high-coverage tests are necessary for enhancements to be
+   accepted. Bug-fixes or new features should be provided with non-regression
+   tests. Tests that verify the correct behavior of the fix or feature. In this


"Tests that verify" -> These tests verify

glemaitre · 2017-05-17T09:42:48Z

    * Documentation and high-coverage tests are necessary for enhancements
      to be accepted.
+      Bug-fixes or new features should be provided with non-regression tests.
+      Tests that verify the correct behavior of the fix or feature. In this


"Tests that verify" -> These tests verify

amueller · 2017-05-18T18:32:06Z

I think in the world of voluntary contributions, presuming something dad
after a week without asking is a bit ... presumptuous

By that measure I'm long gone to dust ^^

amueller · 2017-05-18T18:32:55Z

LGTM, maybe link to wikipedia for regression test?

massich · 2017-05-22T12:48:05Z

ping @amueller @lesteve

lesteve · 2017-05-23T12:11:11Z

-   to be accepted.
+-  Documentation and high-coverage tests are necessary for enhancements to be
+   accepted. Bug-fixes or new features should be provided with non-regression
+   tests. Tests that verify the correct behavior of the fix or feature. In this


I would be even more explicit for bug-fix to say that the test needs to be failing on master and passing in the PR branch.

lesteve · 2017-05-23T13:22:40Z

I think this is good enough, let's not spend more time nitpicking on this one. Merging, thanks a lot!

…arn#8850)

massich changed the title ~~DOC ask for non-regression test for bug-fix Issue #8679~~ [MRG] DOC ask for non-regression test for bug-fix May 9, 2017

puneetmathurDS and others added 4 commits May 10, 2017 11:25

DOC ask for non-regression test for bug-fix

f2ace3e

Apply changes recomended in PR8817

005134e

[PR8817](scikit-learn#8817)

address all the changes in the previous PR

0cfeaf4

Remove tailing spaces

b2f3c8f

massich force-pushed the is8679 branch from 65fdb56 to b2f3c8f Compare May 10, 2017 09:34

Moved the non-regression explanation to How to contribute

a949276

Move bug-fix to pull request checklist

db275f5

glemaitre reviewed May 17, 2017

View reviewed changes

Address @glemaitre suggestions

8861a86

Add wikipedia reference to non-regression tests

bc9a58e

lesteve reviewed May 23, 2017

View reviewed changes

Address some @lesteve suggestions

549dd27

lesteve merged commit 1b5bff3 into scikit-learn:master May 23, 2017

lesteve mentioned this pull request May 23, 2017

DOC ask for non-regression test for bug-fix Issue#8679 #8817

Closed

massich deleted the is8679 branch June 1, 2017 09:44

Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

5c0ae4d

…arn#8850)

dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

5cb397f

…arn#8850)

dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

258db6f

…arn#8850)

NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

2bd819b

…arn#8850)

paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

688fb82

…arn#8850)

AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

34f8ef1

…arn#8850)

maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

bb6e0d4

…arn#8850)

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

[MRG] DOC add documentation on adding non-regression tests (scikit-le…

cfeb07e

…arn#8850)

Uh oh!

Uh oh!

Conversation

massich commented May 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

glemaitre commented May 9, 2017

Uh oh!

jnothman commented May 9, 2017 via email

Uh oh!

naoyak commented May 10, 2017

Uh oh!

massich commented May 10, 2017

Uh oh!

lesteve commented May 10, 2017

Uh oh!

massich commented May 10, 2017

Uh oh!

lesteve commented May 10, 2017

Uh oh!

massich commented May 10, 2017

Uh oh!

massich commented May 10, 2017

Uh oh!

massich commented May 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesteve commented May 11, 2017

Uh oh!

massich commented May 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

glemaitre May 17, 2017

Choose a reason for hiding this comment

Uh oh!

glemaitre May 17, 2017

Choose a reason for hiding this comment

Uh oh!

amueller commented May 18, 2017

Uh oh!

amueller commented May 18, 2017

Uh oh!

massich commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesteve May 23, 2017

Choose a reason for hiding this comment

Uh oh!

lesteve commented May 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

massich commented May 9, 2017 •

edited

Loading

massich commented May 11, 2017 •

edited

Loading

massich commented May 15, 2017 •

edited

Loading

massich commented May 22, 2017 •

edited

Loading