Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] Update URL for species distribution dataset #8864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2017
Merged

[MRG] Update URL for species distribution dataset #8864

merged 2 commits into from
May 11, 2017

Conversation

naoyak
Copy link
Contributor

@naoyak naoyak commented May 11, 2017

The species distribution dataset moved to a new host.

See http://www.cs.princeton.edu/~schapire/maxent/:

This website has moved to the American Museum of Natural History.

@naoyak naoyak changed the title Update URL for species distribution dataset [MRG] Update URL for species distribution dataset May 11, 2017
@naoyak naoyak mentioned this pull request May 11, 2017
Merged
TomDLT
TomDLT reviewed May 11, 2017
View reviewed changes
examples/applications/plot_species_distribution_modeling.py
@@ -31,7 +31,7 @@
----------

* `"Maximum entropy modeling of species geographic distributions"
<http://www.cs.princeton.edu/~schapire/papers/ecolmod.pdf>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.cs.princeton.edu/~schapire/papers/ecolmod.pdf is still accessible to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but given that http://www.cs.princeton.edu/~schapire/ says:

I have moved to Microsoft Research in NYC.
My new website is: rob.schapire.net.

I would be enclined to change all the links.

lesteve
lesteve reviewed May 11, 2017
View reviewed changes
sklearn/datasets/species_distributions.py
@@ -55,7 +55,7 @@
from sklearn.datasets.base import _pkl_filepath
from sklearn.externals import joblib

DIRECTORY_URL = "http://www.cs.princeton.edu/~schapire/maxent/datasets/"
DIRECTORY_URL = "http://biodiversityinformatics.amnh.org/open_source/maxent/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this will fix problems I was seeing with CircleCI on master.

@lesteve
Copy link
Member

lesteve commented May 11, 2017

I have checked that this PR fixed sklearn.datasets.fetch_species_distributions so I am going to merge this one without waiting for the CIs.

@lesteve lesteve merged commit 1af5a0e into scikit-learn:master May 11, 2017
@lesteve
Copy link
Member

lesteve commented May 11, 2017

Of course, that means fetch_species_distribution will be broken in released versions and that we should really try to push #7429 forward to avoid this kind of things in the future.

@naoyak naoyak deleted the update-species-distributions branch May 11, 2017 16:47
@naoyak
Copy link
Contributor Author

naoyak commented May 11, 2017

Relevant examples built successfully:
https://10194-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/auto_examples/neighbors/plot_species_kde.html#sphx-glr-auto-examples-neighbors-plot-species-kde-py
https://10194-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/auto_examples/applications/plot_species_distribution_modeling.html#sphx-glr-auto-examples-applications-plot-species-distribution-modeling-py

@lesteve
Copy link
Member

lesteve commented May 11, 2017

Nice, thanks !

@lesteve lesteve mentioned this pull request May 23, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@naoyak @Sundrique
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
104437a
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@naoyak @dmohns
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
bdaab37
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@naoyak @dmohns
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
1f114ff
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@naoyak @NelleV
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
239b356
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@naoyak @paulha
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
c19147b
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@naoyak @AishwaryaRK
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
eaf5049
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@naoyak @maskani-moh
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
7422e0c
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@naoyak
[MRG] Update URL for species distribution dataset (scikit-learn#8864)
8be3226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

@TomDLT TomDLT TomDLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naoyak @lesteve @TomDLT