[MRG + 1] 13 more examples fixed with matplotlib2.0 update #9029
Conversation
…lotlib2.0 + pep8 fix
…tplotlib2.0 + pep8 fix
…tplotlib2.0 + pep8
|
Can you check flake8 for examples/ensemble/plot_forest_iris.py ? |
| @@ -95,11 +97,14 @@ | |||
| scores = clf.score(X, y) | |||
| # Create a title for each column and the console by using str() and | |||
| # slicing away useless parts of the string | |||
| model_title = str(type(model)).split(".")[-1][:-2][:-len("Classifier")] | |||
| model_title = str(type(model)).split( | |||
| ".")[-1][:-2][:-len("Classifier")] | |||
There was a problem hiding this comment.
Certainly a flake8 pb here ?
| # surfaces. These points are regularly space and do not have a | ||
| # black outline | ||
| xx_coarser, yy_coarser = np.meshgrid(np.arange(x_min, x_max, | ||
| plot_step_coarser), |
There was a problem hiding this comment.
Maybe :
xx_coarser, yy_coarser = np.meshgrid(
np.arange(x_min, x_max, plot_step_coarser),
np.arange(y_min, y_max, plot_step_coarser))
|
somehow flake8 on my local doesn't give this error. I tried the older version 2.5.1 as well. Read on stack over-flow that its an indentation issue. Hopefully its fixed now as I couldn't test it on my local. Will share old/new for this and the other PR once all checks are passed. |
|
OK thanks @aarshayj |
|
cross_decomposition/plot_compare_cross_decomposition.html Old: New: |
|
datasets/plot_iris_dataset.html Old: New: |
|
datasets/plot_random_dataset.html Old: New: |
|
decomposition/plot_kernel_pca.html Old: New: |
|
ensemble/plot_adaboost_twoclass.html Old: New: |
|
ensemble/plot_forest_iris.html Old: New: |
|
ensemble/plot_isolation_forest.html Old: New: |
|
ensemble/plot_partial_dependence.html Old: New: The other image was not changed |
|
ensemble/plot_random_forest_embedding.html Old: New: |
|
ensemble/plot_random_forest_regression_multioutput.html Old: New: |
@amueller - i resolved it back to the default colormap so that the colors of the dots and contour match. i know that it doesn't look great but will that work? using other colors and matching will add some lines of code which will complicate the example. sounds like a fair trade-off? Also, all the plots here are updated with the latest circleCI build. still awaiting Appveyor build to complete. |
|
You can merge master to fix the appveyor builds if you want, but it's not critical because unrelated |
|
LGTM :) |
I didn't get it. How can I merge master? Do you mean merge on my local and send a PR to master directly? |
|
you want to do something like:
git fetch upstream
git merge upstream/master
git push origin
On 20 Jun 2017 9:47 am, "Aarshay Jain" <[email protected]> wrote:
You can merge master to fix the appveyor builds if you want, but it's not
critical because unrelated
I didn't get it. How can I merge master? Do you mean merge on my local and
send a PR to master directly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9029 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6xASCp3bixcxRzbfGjtFUNQwxOAOks5sFwh1gaJpZM4NyM6u>
.
|
|
If you do that, the red cross goes away, which might encourage reviewers ;) |
|
@aarshayj could you do update with master? I'll merge once the CIs pass. This looks good to me. |
|
@raghavrv - i've merged master. pls merge when the tests pass. |
|
LGTM, I merged. Thanks @aarshayj! |
|
was that all of them now @aarshayj ? |
|
Well, thank you very much!
|
13 more examples updated with matplotlib 2.0 updates.
Fixes issue #8364
The old and new plots will be posted soon after circleCI build completes.