[MRG] MNT Use the default flake8 --ignore options #9123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK that looked good to me. I pushed a small change and I'll merge this as soon as the Travis flake8 build passes. |
|
LGTM, although I've not checked what these particular error codes are. |
|
Merged thanks a lot for the PR and the build reproducing the problem! |
|
Thanks! For future reference, the default flake8 errors are (cf [1], [2]),
the flake8 documentation also states,
(which BTW doesn't match with the actual default parameters) |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9121
This makes sure that the the TravisCI flake8 build is using the default flake8
--ignoreoptions, for smoother contribution workflow.. Also checked that these are defaults in the flake8 master branch.As suggested by @lesteve this specifies the ignored errors/warnings explicitly, while keeping one extra ignored error for examples. Unless you think it's better to simply remove the
--ignoreflag for non-examples?cc @jnothman