[MRG+1] Deprecating the use of size_threshold parameter in manhattan_distances #9295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Jul 13, 2017
| @@ -518,6 +519,10 @@ def manhattan_distances(X, Y=None, sum_over_features=True, | |||
| array([[ 1., 1.], | |||
| [ 1., 1.]]...) | |||
| """ | |||
| if size_threshold is not None: | |||
| warnings.warn('Use of the "size_threshold" is deprecated ' | |||
There was a problem hiding this comment.
can you please explicitly mention the version in which it is deprecated (0.19) and the one in which it will be removed (0.21)
There was a problem hiding this comment.
Sure, will do it.
|
thanks :) |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…distances (scikit-learn#9295) * deprecating size_threshold in manhattan_distances * fixing a minor pep8 error * version number for deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes: #9291
What does this implement/fix? Explain your changes.
Added a deprecation warning for using size_threshold parameter in manhattan_distance. Modified the corresponding test function.
Any other comments?