[MRG + 1] Too few arguments in formatting call #9298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jul 8, 2017
| "match the input. Model n_features is {1} and " | ||
| "input n_features is {2} " | ||
| "match the input. Model n_features is {0} and " | ||
| "input n_features is {1} " |
There was a problem hiding this comment.
this means it was not covered by any test. Can you update existing test to catch this pb?
thx
There was a problem hiding this comment.
Yes, I'll check in with tests
SebastinSanty
commented
Jul 13, 2017
| print('ok') | ||
| except: | ||
| print("Unexpected error") | ||
| raise |
There was a problem hiding this comment.
@agramfort Test like this?
|
use assert_raise_message
…On 13 July 2017 at 22:32, Sebastin Santy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sklearn/ensemble/tests/test_bagging.py
<#9298 (comment)>
:
> @@ -448,6 +448,14 @@ def test_parallel_classification():
ensemble.set_params(n_jobs=2)
decisions2 = ensemble.decision_function(X_test)
assert_array_almost_equal(decisions1, decisions2)
+ try:
+ X_err = np.hstack((X_test, np.zeros((X_test.shape[0], 1))))
+ decisionerr = ensemble.decision_function(X_err)
+ except ValueError:
+ print('ok')
+ except:
+ print("Unexpected error")
+ raise
@agramfort <https://github.com/agramfort> Like this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9298 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz65nAtkesjbq6QzvILAOMUzF8l2-bks5sNg5jgaJpZM4ORh_I>
.
|
|
Thanks @jnothman. Covered with tests now. |
|
thx @SebastinSanty |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
* Too few arguments in formatting call * Add test * Covered with tests
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Too few arguments in formatting call * Add test * Covered with tests
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Too few arguments in formatting call * Add test * Covered with tests
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* Too few arguments in formatting call * Add test * Covered with tests
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Too few arguments in formatting call * Add test * Covered with tests
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* Too few arguments in formatting call * Add test * Covered with tests
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Too few arguments in formatting call * Add test * Covered with tests
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* Too few arguments in formatting call * Add test * Covered with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9280
What does this implement/fix? Explain your changes.
Some placeholders for .format() weren't 0 indexed.