Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] affinity passed to _fix_connectivity in linkage_tree #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] affinity passed to _fix_connectivity in linkage_tree #9315

wants to merge 1 commit into from

Conversation

SebastinSanty
Copy link
Contributor

Reference Issue

Fixes #9308

What does this implement/fix? Explain your changes.

_fix_connectivity in sklearn/cluster/hierarchical.py accepts affinity, but is not passed it by linkage_tree.

Any other comments?

This also needs to be covered with tests.

@SebastinSanty
Copy link
Contributor Author

I'll cover this with tests, in sometime.

@TomDLT
Copy link
Member

TomDLT commented Jul 18, 2017 •
edited
Loading

Fixed with a test in #9357

@TomDLT TomDLT closed this Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should affinity be passed to _fix_connectivity in linkage_tree?
2 participants
@SebastinSanty @TomDLT