Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master#9317

Merged
TomDLT merged 3 commits intoscikit-learn:masterfrom
raghavrv:fix_master
Jul 10, 2017
Merged

[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master#9317
TomDLT merged 3 commits intoscikit-learn:masterfrom
raghavrv:fix_master

Conversation

@raghavrv
Copy link
Member

@raghavrv raghavrv commented Jul 10, 2017

The error messages in tests need correction after #9275

@jmschrei @jnothman

@raghavrv raghavrv mentioned this pull request Jul 10, 2017
Merged
@jmschrei
Copy link
Member

jmschrei commented Jul 10, 2017

I don't think that's the issue since the messages got changed more than just the capitalization? I'm pretty sure all the tests were passing when I hit merge.

@raghavrv
Copy link
Member Author

raghavrv commented Jul 10, 2017

Oh yea. the error message is changed by a bit. fixed now. passes travis. Good for merge?

@jmschrei
Copy link
Member

jmschrei commented Jul 10, 2017 •
edited
Loading

Thanks for taking a stab at this. It's weird that this is passing the CI tests. This is the full error for the master branch: AssertionError: "Can't handle mix of binary and continuous" does not match "Classification metrics can't handle a mix of binary and continuous targets", so presumably the text should read

assert_raises_regex(ValueError,  "Classification metrics can't "
    "handle a mix of binary and continuous targets", 
    cross_validate, estimator, X, y, scoring={"foo": multiclass_scorer})

or something like that?

@raghavrv
Copy link
Member Author

raghavrv commented Jul 10, 2017

thanks. have updated the full error message as you suggested.

@raghavrv raghavrv mentioned this pull request Jul 10, 2017
Merged
@TomDLT
Copy link
Member

TomDLT commented Jul 10, 2017 •
edited
Loading

LGTM and CI are green
Merging to avoid more trouble in other PR
Thanks @raghavrv !

@TomDLT TomDLT merged commit add9b7f into scikit-learn:master Jul 10, 2017
@raghavrv raghavrv deleted the fix_master branch July 11, 2017 15:29
massich pushed a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017
@raghavrv
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
5eff3ee 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge tag '0.19b2' into releases
ec9e5de 
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'releases' into dfsg (reremoved joblib and jquery)
4615112 
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'dfsg' into debian
236bb58 
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@raghavrv @dmohns
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
0cfad22 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@raghavrv @dmohns
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
cf4b774 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@raghavrv @NelleV
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
daf7e4d 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@raghavrv @paulha
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
45bbb6b 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@raghavrv @AishwaryaRK
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
a011e7b 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@raghavrv @maskani-moh
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
0fd0b6b 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@raghavrv
[MRG] [HOTFIX] Fix capitalization in test and hence fix failing travi…
e474388 
…s at master (scikit-learn#9317)

* Fix capitalization in test and hence fix master

* Fix error message

* ENH fix tests with full error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raghavrv @jmschrei @TomDLT

Comments