[MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma #9371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631
|
Looks good. Why "WIP"? |
|
Isn't sklearn itself a "WIP", really? |
|
Because I'm a new committer and being overly cautious, thanks! :) |
|
LGTM as well, waiting for tests to finish. |
|
Thanks! Now you have to contribute forever. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…eight_concentration_prior is commonly called gamma in the literature, per scikit-learn#8631 (scikit-learn#9371) [MRG+2] BayesianGaussianMixture docstring change: weight_concentration_prior is commonly called gamma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#8631
What does this implement/fix? Explain your changes.
Adds a note to the BayesianGaussianMixture docstring that weight_concentration_prior is commonly called gamma in the literature.