[MRG+1] use ignore_warnings to catch FutureWarning raised by SGDClassifier #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know of a way |
|
you can raise warnings as errors, right? Or just change that particular warning into a |
|
sounds like a worthwhile feature to have in pytest. raise an issue there if
the feature does not exist? perhaps by adding a hook into the warning
handler?
…On 16 Jul 2017 8:40 am, "David Nicholson" ***@***.***> wrote:
addresses issue #9365
<#9365>
uses ignore_warnings to catch FutureWarning raised by SGDClassifier
I did not yet eliminate the same warning raised by
PassiveAggressiveClassifier, etc.
@amueller <https://github.com/amueller> do you know of a way to get
nosetests / pytests to output the line numbers *from the test files*
where the warning is raised so I can more easily find the other places that
raise this warning? @raghavrv <https://github.com/raghavrv> and Jacob
tried to help me with that but we couldn't figure it out
------------------------------
You can view, comment on, or merge this pull request online at:
#9374
Commit Summary
- use ignore_warning to catch FutueWarning
File Changes
- *M* sklearn/utils/tests/test_estimator_checks.py
<https://github.com/scikit-learn/scikit-learn/pull/9374/files#diff-0>
(10)
Patch Links:
- https://github.com/scikit-learn/scikit-learn/pull/9374.patch
- https://github.com/scikit-learn/scikit-learn/pull/9374.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9374>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEz6y0g-irr0Fjhn8KTpgcS0vwIm8T8ks5sOT_dgaJpZM4OZJQS>
.
|
|
but an easy way would be to set all warnings to raise errors
…On 16 Jul 2017 11:38 am, "Joel Nothman" ***@***.***> wrote:
sounds like a worthwhile feature to have in pytest. raise an issue there
if the feature does not exist? perhaps by adding a hook into the warning
handler?
On 16 Jul 2017 8:40 am, "David Nicholson" ***@***.***>
wrote:
> addresses issue #9365
> <#9365>
>
> uses ignore_warnings to catch FutureWarning raised by SGDClassifier
>
> I did not yet eliminate the same warning raised by
> PassiveAggressiveClassifier, etc.
>
> @amueller <https://github.com/amueller> do you know of a way to get
> nosetests / pytests to output the line numbers *from the test files*
> where the warning is raised so I can more easily find the other places that
> raise this warning? @raghavrv <https://github.com/raghavrv> and Jacob
> tried to help me with that but we couldn't figure it out
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #9374
> Commit Summary
>
> - use ignore_warning to catch FutueWarning
>
> File Changes
>
> - *M* sklearn/utils/tests/test_estimator_checks.py
> <https://github.com/scikit-learn/scikit-learn/pull/9374/files#diff-0>
> (10)
>
> Patch Links:
>
> - https://github.com/scikit-learn/scikit-learn/pull/9374.patch
> - https://github.com/scikit-learn/scikit-learn/pull/9374.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#9374>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/AAEz6y0g-irr0Fjhn8KTpgcS0vwIm8T8ks5sOT_dgaJpZM4OZJQS>
> .
>
|
|
I ran |
I didn't know this command. Nice! LGTM |
|
Thanks |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9365
uses
ignore_warningsto catch FutureWarning raised by SGDClassifierI did not yet eliminate the same warning raised by PassiveAggressiveClassifier, etc.
@amueller do you know of a way to get nosetests / pytests to output the line numbers from the test files where the warning is raised so I can more easily find the other places that raise this warning? @raghavrv and Jacob tried to help me with that but we couldn't figure it out