[MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler #9380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for the contribution! |
|
I would emphasize that doing this transformation on test data might lead to data that is out of bounds / not zero mean. |
|
@amueller Good idea, I will remove .scale_ example and add transform example on test data. |
|
You've added the elastic net changes to this PR. Can you remove them? |
|
@jmschrei Done. |
ogrisel
reviewed
Jul 18, 2017
sklearn/preprocessing/data.py
Outdated
| -------- | ||
| >>> from sklearn.preprocessing import MinMaxScaler | ||
| >>> | ||
| >>> data = [[-1, -1], [-1, -1], [1, 1], [1, 1]] |
There was a problem hiding this comment.
I think the example would be more informative with some intermediate values and different ranges:
>>> data = [[-1, -1], [0, 2], [1, 5]]
|
lgtm |
amueller
approved these changes
Jul 18, 2017
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…er (scikit-learn#9380) [MRG+2] Added examples to docstrings of MinMaxScaler and StandardScaler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses #3846
What does this implement/fix? Explain your changes.
Adds examples to docstrings of MinMaxScaler and StandardScaler
Any other comments?