[WIP] Concise code to obtain estimators for each split in the cross val doc #9496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Aug 6, 2017
Member
jnothman
left a comment
There was a problem hiding this comment.
I'm okay with this, but personally would be happy to include an option to return them from cross_validate, since it would make this work where:
- CV is expressed in a way that it needs to be checked before splitting
- the data is a precomputed kernel
- the data is a DataFrame or a list
You could also define a scoring function which dumped the estimator to disk, but there's no easy way to identify which fold we're dumping. Also, it's a hack.
Contributor
Author
|
Thanks, will create a PR implementing this alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #6827
What does this implement/fix? Explain your changes.
This PR adds a section to the doc "3.1. Cross-validation: evaluating estimator performance" with a concise sample code to obtain estimators for each split.
Note: I included only the version proposed by @lesteve which works for both Python 2 & 3, not the more concise version which works only in Python 3 to avoid clutter:
Any other comments?
This is the first time I contribute to the docs so it would be great to have feedback on the text (should I mention why this may be needed?), formatting (should I use a runnable piece of code instead of a generic "pseudo-code" example?), and whether I placed this in the most appropriate part of doc.