Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jnothman
Copy link
Member

@jnothman jnothman commented Aug 6, 2017

I may be the only person to look at API reference on small screens, but a large chunk of the horizontal space is taken up by the heading "Parameters" or "Attributes" because it is a field-list rendered as a table, with the first column reserved for headings. Yuck. This is a hack to make it look better on small screens. More yuck.

@amueller
Copy link
Member

Can you provide screenshots?

@jnothman
Copy link
Member Author

Before:

screenshot_2017-08-13-21-22-25

After:

screenshot_2017-08-13-21-23-47

@jnothman jnothman changed the title Make parameter, etc listings use small screen width better [MRG] DOC Make parameter, etc listings use small screen width better Feb 13, 2018
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is much nicer on mobile. Thanks @jnothman! I think we should also backport it to stable.

Before / after

renderding

@rth rth changed the title [MRG] DOC Make parameter, etc listings use small screen width better DOC Make parameter, etc listings use small screen width better Jun 16, 2019
@rth rth merged commit cb12053 into scikit-learn:master Jun 16, 2019
@rth rth added this to the 0.21.3 milestone Jun 16, 2019
@jnothman
Copy link
Member Author

jnothman commented Jun 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants