[MRG+1] Avoid occasional failure of test_kernel_ridge_singular_kernel #9542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, if that source of randomness is the issue, then great. |
|
Have you managed to locally reproduce the failure? |
|
@jnothman |
|
@jnothman CIs are green. From my perspective, I tend to believe that the occasional test failure is due to small amount of certain random state. |
|
yeah, i think this is a good fix
…On 14 Aug 2017 1:22 am, "Hanmin Qin" ***@***.***> wrote:
@jnothman <https://github.com/jnothman> CIs are green. From my
perspective, I tend to believe that the occasional test failure is due to
small amount of certain random state.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9542 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz67hVvKgo_QdAvVDrPNBo16oVdOdTks5sXxSYgaJpZM4O1s-g>
.
|
|
LGTM |
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9535
What does this implement/fix? Explain your changes.
I'll try to only add a random state to ensure a certain output of the test.
From my perspective, it's enough if CIs are green.
Kindly tell me if we need to reduce the decimal requirement of assert_array_almost_equal.
Any other comments?