Deprecated argument names in hdbscan_.py #673
Conversation
|
This change also increases the minimum required scikit-learn version from 0.2 to 1.6. Maybe it is worth testing which version is available at run-time to keep support for older scikit-learn versions? |
|
If dependencies were declared in pyproject.toml, it would be straightforward to specify scikit-learn version for given python versions. Is there interest in setting that up instead of requirements.txt? |
|
scikit-learn 1.8 will probably be released today. Depending on how many past versions of scikit-learn you want to support it might be worth investigating https://github.com/sklearn-compat/sklearn-compat#validate_data-function to make it easier to deal with the various deprecations. |
|
Hello, we use (and love) hdbscan in the spikeinterface package. Would be great if this, or a similar PR, could make hdbscan compatible with scikit-learn v1.8 :) |
Sklearn deprecated
force_all_finiteparam for check_array(). Docs here. There is a deprecation warning when fitting the model. check_array function is used twice in hdbscan_.py. Changed both to new param namingensure_all_finite, functionality is identical.