Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] Fix test for components_from_metric and add tests for _check_sdp_from_eigen #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2020
Merged

[MRG] Fix test for components_from_metric and add tests for _check_sdp_from_eigen #303

merged 3 commits into from
Aug 3, 2020

Conversation

wdevazelhes
Copy link
Member

Fixes #264
See #264 (comment)

This PR fixes the test that was failing test_components_from_metric_edge_cases, and at the same time tests better _check_sdp_from_eigen

bellet
bellet approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@bellet bellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks. LGTM if the CI passes

@bellet
Copy link
Member

bellet commented Aug 3, 2020

There are just some linting errors to fix before we can merge

@wdevazelhes
Copy link
Member Author

All CIs are green, merging

@wdevazelhes wdevazelhes merged commit 617adaa into scikit-learn-contrib:master Aug 3, 2020
@bellet
Copy link
Member

bellet commented Aug 3, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellet bellet bellet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing test_components_from_metric_edge_cases breaks around line 130 on some environments
2 participants
@wdevazelhes @bellet