Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not mutate features in __init__. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not mutate features in __init__. #105

wants to merge 1 commit into from

Conversation

jimmywan
Copy link

Taking a stab at #76.

Before:

$ python -m doctest README.rst
/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/sklearn-pandas/lib/python3.6/site-packages/sklearn/utils/validation.py:429: DataConversionWarning: Data with input dtype int64 was converted to float64 by StandardScaler.
  warnings.warn(msg, _DataConversionWarning)
/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/sklearn-pandas/lib/python3.6/site-packages/sklearn/base.py:122: DeprecationWarning: Estimator DataFrameMapper modifies parameters in __init__. This behavior is deprecated as of 0.18 and support for this behavior will be removed in 0.20.
  % type(estimator).__name__, DeprecationWarning)
/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/sklearn-pandas/lib/python3.6/site-packages/sklearn/base.py:122: DeprecationWarning: Estimator DataFrameMapper modifies parameters in __init__. This behavior is deprecated as of 0.18 and support for this behavior will be removed in 0.20.
  % type(estimator).__name__, DeprecationWarning)
/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/sklearn-pandas/lib/python3.6/site-packages/sklearn/base.py:122: DeprecationWarning: Estimator DataFrameMapper modifies parameters in __init__. This behavior is deprecated as of 0.18 and support for this behavior will be removed in 0.20.
  % type(estimator).__name__, DeprecationWarning)

After:

$ python -m doctest README.rst
/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/sklearn-pandas/lib/python3.6/site-packages/sklearn/utils/validation.py:429: DataConversionWarning: Data with input dtype int64 was converted to float64 by StandardScaler.
  warnings.warn(msg, _DataConversionWarning)

@jimmywan jimmywan mentioned this pull request Jun 21, 2017
Closed
dukebody added a commit that referenced this pull request Jun 24, 2017
@dukebody
Do not mutate features in __init__
f784956 
This is to comply with sklearn>=0.20 which requires that
no parameters are mutated in __init__ to be able to make
cross-validation wrappers work easily.

See scikit-learn/scikit-learn#5540

Resolves #76.

Code based on PR #105 by @jimmywan
@dukebody
Copy link
Collaborator

Thanks a lot for your contribution! ❤️

I checked in a slightly modified version of this PR in f784956.

@dukebody dukebody closed this Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmywan @dukebody