Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC/MAINT: optimize: fix some typos#21634

Merged
lucascolley merged 1 commit into
scipy:mainfrom
vaerksted:main
Sep 27, 2024
Merged

DOC/MAINT: optimize: fix some typos#21634
lucascolley merged 1 commit into
scipy:mainfrom
vaerksted:main

Conversation

@musvaage
Copy link
Copy Markdown
Contributor

@musvaage musvaage commented Sep 27, 2024

@lucascolley

dumped directory strings exposed a few typos

the sole C language files modified are in the tnc subdirectory

check that the replacement string in this file is correct

$ grep -nr neigbouds scipy/scipy/optimize
scipy/scipy/optimize/_shgo_lib/_complex.py:1049:                        pass  # NOTE: Not all neigbouds are in initial pool
$

@musvaage musvaage requested a review from andyfaff as a code owner September 27, 2024 16:47
@github-actions github-actions Bot added scipy.optimize C/C++ Items related to the internal C/C++ code base Cython Issues with the internal Cython code base Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks labels Sep 27, 2024
@lucascolley lucascolley removed C/C++ Items related to the internal C/C++ code base Cython Issues with the internal Cython code base labels Sep 27, 2024
@musvaage
Copy link
Copy Markdown
Contributor Author

musvaage commented Sep 27, 2024 •
edited
Loading

dumped directory strings

misc and odr

in the former no indicated string corrections

the latter's odrpack subdirectory's files contain a few typos

ALGORITHM
COLUMNS
DERIVATIVES
INDICATES
IMPLICIT
ITERATION
MATHEMATICS
REPRESENTS
STOPPED
VARIABLE

$ grep -nr ALGORTIHM scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:9379:C                 AS ALGORTIHM 70 OF APPLIED STATISTICS.
scipy/scipy/odr/odrpack/d_odr.f:9387:C                 DISTRIBUTION, ALGORTIHM 70, APPLIED STATISTICS, 1974,
$ grep -nr COLUMNNS scipy/scipy/odr
scipy/scipy/odr/odrpack/d_lpk.f:615:C     FORMED FROM COLUMNNS JPVT(1), ... ,JPVT(K) OF THE ORIGINAL
$ grep -nr DERVIATIVES scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:3114:C            DISAGREEMENT BETWEEN THE NUMERICAL AND ANALYTIC DERVIATIVES
$ grep -nr INDICTES scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:6258:C            ODRPACK. A POSITIVE VALUE INDICTES THE VALUE WAS SUPPLIED
$ grep -nr INPLICIT scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:4228:C   DONE:    THE VARIABLE DESIGNATING WHETHER THE INPLICIT SOLUTION HAS
$ grep -nr INTERATION scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:5939:C  BEGIN NEXT INTERATION UNLESS A STOPPING CRITERIA HAS BEEN MET
$ grep -nr MATHMATICS scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:9503:C***REFERENCES  NATIONAL BUREAU OF STANDARDS APPLIED MATHMATICS
$ grep -nr REPRESENTES scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:9381:C                 STATISTICS, THEIR ALGORITHM REPRESENTES A
$ grep -nr STOPED scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:5090:C            STOPED DUE TO SOME NUMERICAL ERROR DETECTED WITHIN
scipy/scipy/odr/odrpack/d_odr.f:5438:C            STOPED DUE TO SOME NUMERICAL ERROR WITHIN ROUTINE DODSTP.
scipy/scipy/odr/odrpack/d_odr.f:8720:C            STOPED DUE TO A NUMERICAL ERROR WITHIN SUBROUTINE DODSTP.
scipy/scipy/odr/odrpack/d_odr.f:9116:C            STOPED DUE TO A NUMERICAL ERROR WITHIN SUBROUTINE DODSTP.
$ grep -nr VARIABEL scipy/scipy/odr
scipy/scipy/odr/odrpack/d_odr.f:2172:C   NITERI:  THE LOCATION IN ARRAY IWORK OF VARIABEL NITER.
$

MATRIX

$ sed -n '10591p' scipy/scipy/odr/odrpack/d_odr.f
C  WT IS A DIAGONAL MATRICE
$

cf: #12283

the pull deleted d_lpkbls.f

scipy/odr/odrpack/Makefile

- OBJS = d_odr.o d_mprec.o d_lpkbls.o dlunoc.o
+ OBJS = d_odr.o d_mprec.o dlunoc.o

my schedule has changed so I won't be spending further time on reviews of the documentation

rkern
rkern reviewed Sep 27, 2024
View reviewed changes
Comment thread scipy/optimize/_trustregion_exact.py Outdated
@musvaage musvaage marked this pull request as draft September 27, 2024 18:40
@musvaage musvaage marked this pull request as ready for review September 27, 2024 18:49
lucascolley
lucascolley approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lucascolley lucascolley merged commit d6d5b86 into scipy:main Sep 27, 2024
@musvaage
Copy link
Copy Markdown
Contributor Author

musvaage commented Sep 27, 2024

@DimitriPapadopoulos

corpus of codespell

to date checked these subdirectories, merged pull numbers follow

$ tree -d -L 1 --noreport scipy/scipy | tail
|-- linalg
|-- misc
|-- ndimage
|-- odr
|-- optimize
|-- signal
|-- sparse
|-- spatial
|-- special
`-- stats
$

#21573, #21585, #21586, #21607, #21617, #21621, #21624, #21634

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
Typos found in Scipy
1a12f26 
scipy/scipy#21573
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
Typos found in Scipy
e13de7a 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
c5d434c 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
52a8242 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
@musvaage
Copy link
Copy Markdown
Contributor Author

musvaage commented Sep 27, 2024

in the odrpack directory I'm neither going to implement the typo fixes nor remove the errant string from the Makefile

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
5a620ba 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to codespell-project/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
31ceeed 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
@musvaage
Copy link
Copy Markdown
Contributor Author

musvaage commented Oct 14, 2024 •
edited
Loading

this is only for my own records

https://github.com/xiaoyeli/superlu/pull/159

typo fixes were merged in SuperLU; .html files not regenerated which as I'm informed may happen prior to a new release

@dschmitz89 and others have committed to the bundled code

https://github.com/qhull/qhull/pull/148 (Closed)

upstream qhull pull was never reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkern rkern rkern left review comments

@lucascolley lucascolley lucascolley approved these changes

@andyfaff andyfaff Awaiting requested review from andyfaff andyfaff is a code owner

Assignees

No one assigned

Labels

Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks scipy.optimize

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@musvaage @rkern @lucascolley