ENH: stats.epps_singleton_2samp: vectorize implementation #23881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bowhay
reviewed
Oct 29, 2025
lucascolley
previously requested changes
Oct 29, 2025
lucascolley
reviewed
Oct 29, 2025
mdhaber
commented
Oct 29, 2025
Co-authored-by: Jake Bowhay <[email protected]>
lucascolley
approved these changes
Oct 29, 2025
j-bowhay
approved these changes
Oct 29, 2025
j-bowhay
reviewed
Oct 29, 2025
| to be evaluated. It should be positive distinct numbers. The default | ||
| value (0.4, 0.8) is proposed in [1]_. Input must not have more than | ||
| one dimension. | ||
| axis : int or tuple of ints, default: None |
Member
There was a problem hiding this comment.
Oops I missed this the default axis is 0
Contributor
Author
There was a problem hiding this comment.
Ah good catch. Fortunately, this renders correctly online (and with help).
In the past, I've added it because reviewers wanted to see it in the code, but because it's invisible to the user, I just copy-pasted from _xp_mean. Oops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-14651
Toward gh-20544
What does this implement/fix?
This vectorizes the implementation of
scipy.stats.epps_singleton_2sampand prepares for array API translation.Additional information
This relies on the
_apply_over_batchdecorator to vectorizexpx.cov, but I opened data-apis/array-api-extra#502 about vectorizing the implementation itself.