Merged
Conversation
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
Signed-off-by: Ben Meier <[email protected]>
mathieu-benoit
approved these changes
Oct 28, 2024
Contributor
mathieu-benoit
left a comment
There was a problem hiding this comment.
That's a really strong start, @astromechza, LGTM!
Signed-off-by: Ben Meier <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of Score to the implementation sample.
This does not include resource provisioners! The resources here are simply validated and then set with empty outputs.
The workload conversion just interpolates the variables and files and then outputs the specs into the manifests.yaml file.
This repo is set as a template repo, to start creating a new Score implementation, someone can clone this as a template in Github and then start modifying the resource provisioning and conversion functions straight away!