Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix sign for OK: decode is not needed and break sign for special cases #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sign for OK: decode is not needed and break sign for special cases #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...pis/src/main/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiOAuthService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public OdnoklassnikiOAuthService(OdnoklassnikiApi api, String apiKey, String api
@Override
public void signRequest(String accessToken, OAuthRequest request) {
//sig = lower(md5( sorted_request_params_composed_string + md5(access_token + application_secret_key)))
try {
final String tokenDigest = md5(accessToken + getApiSecret());

final ParameterList queryParams = request.getQueryStringParams();
Expand All @@ -47,13 +46,10 @@ public void signRequest(String accessToken, OAuthRequest request) {
.append(param.getValue());
}

final String sigSource = URLDecoder.decode(stringParams.toString(), "UTF-8") + tokenDigest;
final String sigSource = stringParams + tokenDigest;
request.addQuerystringParameter("sig", md5(sigSource).toLowerCase());

super.signRequest(accessToken, request);
} catch (UnsupportedEncodingException unex) {
throw new IllegalStateException(unex);
}
}

public static String md5(String orgString) {
Expand Down
10 changes: 10 additions & 0 deletions ...apis/src/test/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ public void testSigGeneration() {
final OAuthRequest request = new OAuthRequest(Verb.GET, URL);
service.signRequest(accessToken, request);
assertEquals("96127f5ca29a8351399e94bbd284ab16", findParam(request.getQueryStringParams(), "sig"));

final OAuthRequest request2 = new OAuthRequest(Verb.GET, URL);
request2.addQuerystringParameter("testsimpleparam", "simplevalue");
service.signRequest(accessToken, request2);
assertEquals("b5355cfc4683869e802747d8aa8acf3f", findParam(request2.getQueryStringParams(), "sig"));

final OAuthRequest request3 = new OAuthRequest(Verb.GET, URL);
request3.addQuerystringParameter("testsimpleparam", "complex+value%20");
service.signRequest(accessToken, request3);
assertEquals("229fd8a3fbc42cf545627e6ea719c57d", findParam(request3.getQueryStringParams(), "sig"));
}

private static String findParam(ParameterList list, String key) {
Expand Down