Adding recursive rendering for collection #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2016 14:59
|
I have log an issue in my repository regarding this change. I didn't manage the infinite loop case for the moment. |
|
Once you are done with it , please comment it out here. So that , I will check it out and we will start to merge your changes . |
|
Worked for me. |
|
Have you done a test ? |
|
Oops . I have been busy lately. Thanks for your contribution man. I think you should be a collaborator in this project. I really appreciate your work here. Please close this PR and commit directly to the repo. |
derrekmc
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hereunder a description of the modifications done :
collection,beginhtmltext,endhtmltext)beginhtmltextendhtmltextAs it is my first pull request not sure how to do it.