TINSEL: Handle DW2 saves that had Noir-sized SysVars - #4661
Merged
Conversation
With this change we now once again can read pre 2.6 savegames. Similarly savegames created after this fix will be readable by ScummVM < 2.6.0. We will also be able to load savegames created by ScummVM 2.6.x. The only limitation is that since we now create the same kind of savegames as older versions again, ScummVM 2.6.x will be unable to load savegames created after this. This fixes bug #13897
Member
Author
|
The original issue was introduced here: eccf066 |
Contributor
|
Thanks! I can't comment on the code itself, but this change appears to work fine with the various <2.6.0 and >2.6.0 saves I have here 👍 If this gets merged, this should probably be cherry-picked to branch-2-7 IMO |
Member
|
Thanks, this addresses this unwanted regression in a clean manner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we now once again can read pre 2.6 savegames. Similarly savegames created after this fix will be readable by ScummVM < 2.6.0. We will also be able to load savegames created by ScummVM 2.6.x.
The only limitation is that since we now create the same kind of savegames as older versions again, ScummVM 2.6.x will be unable to load savegames created after this.
This fixes bug #13897