Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TESTBED: Add shader compatibility tests and remove incompatible shaders from Emscripten build - #6990

Merged
bluegr merged 3 commits into
scummvm:masterfrom
chkuendig:pr/shader-compatibility
Nov 15, 2025
Merged

TESTBED: Add shader compatibility tests and remove incompatible shaders from Emscripten build#6990
bluegr merged 3 commits into
scummvm:masterfrom
chkuendig:pr/shader-compatibility

Conversation

@chkuendig

@chkuendig chkuendig commented Oct 29, 2025

Copy link
Copy Markdown
Member

I noticed that many of the shaders we imported from libretro are not compatible with WebGL (and probably with OpenGL ES either). Having ~30% of the selection in the options not work is not great. This PR changes three things:

  • Add a test to testbed that tests all shaders in shaders.dat as part of the graphics subset tests (can be run in non-interactive mode) and reports which shaders are incompatible.
  • Removes these shaders in the dist-emscripten build target in the relevant makefile.
  • Removes the shader update button in Emscripten, since it has no use there (if we want to update the shaders, we can just replace the default shader.dat file on the server) and might download incompatible shaders.

@criezy

criezy commented Oct 29, 2025

Copy link
Copy Markdown
Member

I am guessing adding an empty shader.cpp file in testbed is not really needed? 😉

@chkuendig
chkuendig force-pushed the pr/shader-compatibility branch from 9ffc7d1 to c9c5c7b Compare October 29, 2025 19:45
@chkuendig

Copy link
Copy Markdown
Member Author

I am guessing adding an empty shader.cpp file in testbed is not really needed? 😉

fixed 🙈

@chkuendig
chkuendig force-pushed the pr/shader-compatibility branch from c9c5c7b to 783a8c5 Compare October 30, 2025 22:09
@bluegr

bluegr commented Nov 15, 2025

Copy link
Copy Markdown
Member

Nice work, thanks!

@bluegr
bluegr merged commit 356d658 into scummvm:master Nov 15, 2025
1 check passed
@chkuendig
chkuendig deleted the pr/shader-compatibility branch November 19, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants